Skip to content

dgram,test: add tests for setBroadcast()

Rodrigo Muino Tomonari requested to merge github/fork/Trott/larry into master
Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

dgram test

Description of change

The only tests for setBroadcast() (from the dgram module) were in test/internet which means they almost never get run. This adds a minimal test that can check JS-land functionality in test/parallel.

Since I was doing the necessary git spelunking anyway, I took the time to add the YAML information into the docs about when setBroadcast() first appeared in its current form.

I also expanded a comment and did some minor formatting on the existing test/internet test. If there were an easy and reliable way to check for the BROADCAST flag on an interface, it's possible that a version of the test could be moved to test/sequential or test/parallel once it was modified to only use internal networks.

Merge request reports