Skip to content

child_process: measure buffer length in bytes

Rodrigo Muino Tomonari requested to merge github/fork/Trott/bytes into master
Checklist

child_process test

  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

child_process test

Description of change

This change fixes a known issue where maxBuffer limits by characters rather than bytes.

Fixes: https://github.com/nodejs/node/issues/1901

Probably need to benchmark it against the current implementation. It's entirely possible no one has done it this way because of performance?

Merge request reports