build: Update build-addons when node-gyp changes.
Partially addresses https://github.com/nodejs/node/issues/4607 by ensuring that build-addons
are rebuilt when node-gyp
is updated.
Checklist
-
tests and code linting passes -
the commit message follows commit guidelines
Affected core subsystem(s)
build
Description of change
We can tell when node-gyp
is changed by creating a prerequisite on
deps/npm/node_modules/node-gyp/package.json
. The prerequisite is added
to the test/addons/.buildstamp
since build-addons
is .PHONY.
Testing for this change was entirely manual.
$ make clean test-build # Initial build
$ make test-build # Make sure build-addons doesn't rebuild
$ touch deps/npm/node_modules/node-gyp/package.json # simulate change
$ make test-build # Ensure build-addons rebuilds