Skip to content

buffer: Fix dataview-set benchmark.

Rodrigo Muino Tomonari requested to merge github/fork/RReverser/buffer-dataview-bench into master
Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

buffer

Description of change

Just fixes a benchmark code itself to provide proper measurement.

Improves numbers up to 4x by avoiding repetitive dynamic method lookup.

Before the change:

buffers\dataview-set.js type=Uint8 millions=1: 4.52066
buffers\dataview-set.js type=Uint16LE millions=1: 5.03784
buffers\dataview-set.js type=Uint16BE millions=1: 5.36833
buffers\dataview-set.js type=Uint32LE millions=1: 4.49819
buffers\dataview-set.js type=Uint32BE millions=1: 4.46667
buffers\dataview-set.js type=Int8 millions=1: 5.52648
buffers\dataview-set.js type=Int16LE millions=1: 5.54321
buffers\dataview-set.js type=Int16BE millions=1: 5.48971
buffers\dataview-set.js type=Int32LE millions=1: 5.61572
buffers\dataview-set.js type=Int32BE millions=1: 5.48682
buffers\dataview-set.js type=Float32LE millions=1: 5.43213
buffers\dataview-set.js type=Float32BE millions=1: 5.49020
buffers\dataview-set.js type=Float64LE millions=1: 5.41688
buffers\dataview-set.js type=Float64BE millions=1: 5.15072

After the change:

buffers\dataview-set.js type=Uint8 millions=1: 19.16623
buffers\dataview-set.js type=Uint16LE millions=1: 17.47599
buffers\dataview-set.js type=Uint16BE millions=1: 17.82669
buffers\dataview-set.js type=Uint32LE millions=1: 11.06974
buffers\dataview-set.js type=Uint32BE millions=1: 11.06411
buffers\dataview-set.js type=Int8 millions=1: 19.36784
buffers\dataview-set.js type=Int16LE millions=1: 13.45155
buffers\dataview-set.js type=Int16BE millions=1: 11.97407
buffers\dataview-set.js type=Int32LE millions=1: 18.88772
buffers\dataview-set.js type=Int32BE millions=1: 18.31484
buffers\dataview-set.js type=Float32LE millions=1: 18.33773
buffers\dataview-set.js type=Float32BE millions=1: 15.50081
buffers\dataview-set.js type=Float64LE millions=1: 16.86952
buffers\dataview-set.js type=Float64BE millions=1: 17.21089

(Just noticed this when going through #6893 and couldn't pass by.)

Merge request reports