Skip to content

doc: addresses nits in string_decoder, url, util

Rodrigo Muino Tomonari requested to merge github/fork/Fishrock123/docs-nits into master
Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change
  • Only @@toStringTag affects util.isError(), this is the reason why we use Object.prototype.toString.call(argument)
  • Shows an actual Euro symbol for reference
  • Uses ascii-line-drawing characters for the URL chart & fixes the chart borders

Here's an example of the old and new chart: https://gist.github.com/Fishrock123/72cbf0b687573e1fc1f54622f05f6354

As a note, not all fonts may have proper font widths for all characters, so it is possible it may not show up perfectly in your editor depending on the font used. (I use a customized font in my editor.)

cc @jasnell & @nodejs/documentation

Merge request reports