Skip to content

Backporting Async Wrap changes

Rodrigo Muino Tomonari requested to merge github/fork/AndreasMadsen/v4.x-async-wrap-backport into v4.x-staging
Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

src, http, http_parser, test, async_wrap

Description of change

Async Wrap in 4.x is very far behind and it creates a lot of issues, see the issue references in https://github.com/nodejs/LTS/issues/86. I recall in some discussion (I can't find it) that this shouldn't be straight forward, however it was actually really easy and all the tests passes. Am I missing something?

This backports the following changes:

  1. https://github.com/nodejs/node/pull/4507 - src: fix MakeCallback error handling
  2. https://github.com/nodejs/node/commit/b72dbdbe430ef83c73cf535bc0dabdba2a64b352 from nodejs/node#5233 - src: remove unnecessary check
  3. https://github.com/nodejs/node/pull/4600 - async_wrap: add uid argument to all asyncWrap hooks
  4. https://github.com/nodejs/node/pull/5419 - http_parser: use MakeCallback
  5. https://github.com/nodejs/node/pull/5591 - src,http: fix uncaughtException miss in http
  6. https://github.com/nodejs/node/pull/5756 - Asyncwrap more

/cc @TheAlphaNerd @trevnorris

Merge request reports