Skip to content

debugger: fix --debug-brk interaction with -e

Rodrigo Muino Tomonari requested to merge github/fork/Trott/debugeval into master
Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

debugger

Description of change

The command line flag --debug-brk was ignored when the -e flag was also present. This change allows the flags to both be honored when they are used in a single command line.

Fixes: https://github.com/nodejs/node/issues/3589

This changes some stack traces due to its modifications to lib/internal/bootstrap_node.js. Not sure if that's considered undesirable or not, but I imagine it could be modified to avoid that. See changes to expected output of messages tests to see what the changes are.

Not sure if this fixes a valid use case or not, but there's an issue open for it and there seems to be a history. @bnoordhuis surely knows more.

R=@bnoordhuis? @indutny?

Merge request reports