Skip to content

buffer,string_decoder: consolidate encoding validation logic

Rodrigo Muino Tomonari requested to merge github/fork/jasnell/normalized-encoding into master
Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

buffer, string_decoder

Description of change

Buffer.isEncoding and string_decoder.normalizeEncoding shared quite a bit of logic. This moves the primary logic into internal/util. The userland modules that monkey patch Buffer.isEncoding should still work.

@nodejs/buffer @mscdex

Merge request reports