Skip to content

http: fix no dumping after `maybeReadMore`

Rodrigo Muino Tomonari requested to merge github/fork/indutny/fix/http-no-read-no-dump into master
Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

http

Description of change

When maybeReadMore kicks in on a first bytes of incoming data, the req.read(0) will be invoked and the req._consuming will be set to true. This seemingly harmless property leads to a dire consequences: the server won't call req._dump() and the whole HTTP/1.1 pipeline will hang (single connection).

Merge request reports