Skip to content

test: add tests for ensuring proper timer delays

Rodrigo Muino Tomonari requested to merge github/fork/Fishrock123/timers/proper-delay-tests into master
Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

tests, timers

Description of change

Adds some test cases for https://github.com/nodejs/node/issues/5426 ... it's a pretty strange bug and I'm not immediately sure what is going on but it may be useful to have these in here so we don't accidentally regress while trying to fix it.

Includes a passing test that should keep passing and an issue test to be fixed.

Note: I think the known_issues test is testing the correct thing, but verification would be helpful.

See also: https://github.com/nodejs/node/issues/7346 & https://github.com/nodejs/node/issues/7386

cc @nodejs/testing and also @misterdjules

Merge request reports