Skip to content

deps: remove extra field from v8::HeapStatistics

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/v8-5.0-abi-compat into master
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps/v8

Description of change

Remove the _malloced_memory field from the HeapStatistics class to achieve full ABI compatibility with V8 5.0 (as far as I can tell).

This structure is probably not something used by addons anyway, since the information from that struct is already made available through Node’s v8.getHeapStatistics(), but better safe than sorry.

Ref: https://github.com/nodejs/node/pull/7016#issuecomment-229986752 (and it would need to be landed in v6 together with #7016).

/cc @ofrobots @nodejs/v8

Merge request reports