Skip to content

build: respect --shared-* flags for inspector deps

Rodrigo Muino Tomonari requested to merge github/fork/ChALkeR/inspector-shared-deps into master
Checklist
  • make -j4 test passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Description of change

Don't build openssl/http_parser/libuv for v8_inspector if corresponding --shared-* flags were passed to the ./configure script.

Fixes: https://github.com/nodejs/node/issues/7478

./configure --shared-openssl --without-intl --shared-http-parser; make -j4 test works and doesn't build openssl and http-parser even with v8_inspector enabled. #7486 fixed that only for the case when --without-inspector was passed.

CI: https://ci.nodejs.org/job/node-test-pull-request/3194/

/cc @bnoordhuis @ofrobots

Merge request reports