Skip to content

src: disable stdio buffering

Rodrigo Muino Tomonari requested to merge github/fork/bnoordhuis/disable-stdio-buffering into master

Disable stdio buffering, it interacts poorly with printf() calls from elsewhere in the program (e.g., any logging from V8.) Unbreaks among other things the --trace_debug_json switch.

Undoes commit 0966ab99 ("src: force line buffering for stderr"), which in retrospect is not a proper fix. Turning on line buffering fixed a flaky test on SmartOS but the test wasn't failing on other platforms, where stderr wasn't line-buffered either.

Disabling buffering should be safe even when mixed with non-blocking stdio I/O because libuv goes to great lengths to reopen the tty file descriptors and falls back to blocking I/O when that fails.

R=@trott?

Merge request reports