Skip to content

Fix tty tests

Rodrigo Muino Tomonari requested to merge github/fork/Fishrock123/fix-tty-tests into master
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, tty

Description of change

Found these while investigating https://github.com/nodejs/node/pull/7360.

Turns out test-tty-wrap.js hasn't worked for over a year. test-tty-stdout-end.js works because the same functionality just so happens to also exist on PipeWraps.

Commit 1 is to preserve the file history correctly.

CI: https://ci.nodejs.org/job/node-test-pull-request/3219/

R: @nodejs/testing I suppose

Merge request reports