Skip to content

backport: update build-addons when node-gyp changes

Rodrigo Muino Tomonari requested to merge github/fork/lance/build-addons-backport into v4.x-staging
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Description of change

Backported from https://github.com/nodejs/node/commit/99bf6face5a7eab6b600507c55b65b98033a4554

We can tell when node-gyp is changed by creating a prerequisite on deps/npm/node_modules/node-gyp/package.json. The prerequisite is added to the test/addons/.buildstamp since build-addons is .PHONY.

Testing for this change was entirely manual.

$ make clean test-build # Initial build $ make test-build # Make sure build-addons doesn't rebuild $ touch deps/npm/node_modules/node-gyp/package.json # simulate change $ make test-build # Ensure build-addons rebuilds

Original PR-URL: https://github.com/nodejs/node/pull/6787

Merge request reports