Skip to content

readline: show completions only after 2nd TAB

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/readline-tab-2nd-completion into master
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

readline

Description of change

Show TAB completion suggestions only after the user has pressed TAB twice in a row, so that the full list of suggestions doesn’t present a distraction. The first time a TAB key is pressed, only partial longest-common-prefix completion is performed.

This moves the readline autocompletion a lot closer to what e.g. bash does.

Fixes: https://github.com/nodejs/node/issues/7665

This is arguably an exclusively human-facing part of the readline functionality, so the semver-major label is up for debate.

Merge request reports