Skip to content

timers: fix cleanup of nested same-timeout timers

Rodrigo Muino Tomonari requested to merge github/fork/erinishimoticha/erinspice/wrong-timer-list-deleted into master
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

timers

Description of change

For nested timers with the same timeout, we can get into a situation where we have recreated a timer list immediately before we need to clean up an old timer list with the same key. Fix: make sure the list to be deleted is the same instance as the list whose reference was used to determine that a cleanup is necessary. If it's not the same instance, a new list with the same key has been created, and it should not be deleted.

Fixes: https://github.com/nodejs/node/issues/7722

Merge request reports