Skip to content

build: adding config.gypi dep to addons/.buildstamp

Rodrigo Muino Tomonari requested to merge github/fork/danbev/clean-test-addons into master
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Description of change

Currently the build-addons target is called as part of the test target, and it has test/addons/.buildstamp as a dependency. When running ./configure --debug and later switching/ updating branches you can be in a situation where the config.gypi files in the addons build directories are using an incorrect value for default_configuration. Currently this can happen and you will get test errors as there are a few test that depend on the value of default_configuration to be Release. When this happens it might not be obvious to someone new to the project (like me) to correct this state. This commit attempts to make it easier to fix this.

The suggestion here is if you find yourself in the above situation the the following steps would be preformed:

1) make clean
2) ./configure
3) make -j4 test

The target distclean also calls clean-addons so that could be used instead of clean in the above example. Also clean-addons could be called directly if required.

This commit is related to #7860 (closed). Please see the dicussion in that issue regarding the test using hard-coded paths.

Merge request reports