Skip to content

Revert "fs: validate args of truncate functions in js"

Rodrigo Muino Tomonari requested to merge github/fork/MylesBorins/revert-fs-changes-part-one into master
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

fs

Description of change

This reverts commit c86c1eea.

original commit message:

This patch

 1. moves the basic validation of arguments to `truncate` family
    of functions to the JavaScript layer from the C++ layer.

 2. makes sure that the File Descriptors are validated strictly.

PR-URL: #2498
Reviewed-By: Trevor Norris <trev.norris@gmail.com>

This commit needs to be reverted in order to revert https://github.com/nodejs/node/commit/9359de9dd2eae06ed5afcb75dad9bd4c466eb69d

Please see more about the discussion in https://github.com/nodejs/node/pull/7846

Merge request reports