Skip to content

deps: float gyp patch for long filenames

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/gyp-filename-float into master
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools/gyp

Description of change

Pulling in https://codereview.chromium.org/2019133002/ in its current state, as gyp seems to be largely abandoned as a project.

Original commit message:

Hash intermediate file name to avoid ENAMETOOLONG

Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.

Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.

The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.

Concretely, this makes the V8 inspector build currently fail when long pathnames are involved, notably when using ecryptfs which has a lower file name length limit.

Fixes: https://github.com/nodejs/node/issues/7959 Ref: https://github.com/nodejs/node/issues/7510

Merge request reports