Skip to content

assert: Fix deepEqual/deepStrictEqual on equivalent typed arrays

Rodrigo Muino Tomonari requested to merge github/fork/feross/fix-8001 into master
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests are included
  • commit message follows commit guidelines
Affected core subsystem(s)

assert

Description of change

Fix #8001 (closed).

The typed array's underlying ArrayBuffer is used in Buffer.from. Let's respect it's .byteOffset or .byteLength (i.e. position within the parent ArrayBuffer).

Merge request reports

Loading