Skip to content

inspector: fix inspector hung while disconnecting

Rodrigo Muino Tomonari requested to merge github/fork/alexkozy/fix-hung-on-disconnect into master
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

If user during stepping make some actions (e.g. stepOver native call) that requests program break and disconnect DevTools frontend then AgentImpl won't be disconnected until other message from frontend.

The root of issue:

  1. Inspector requests program break.
  2. User requests disconnect (e.g. refresh page with DevTools frontend).
  3. On program break V8Inspector call runMessageLoopOnPause on V8NodeInspector.
  4. Message loop will wait until next message from frontend.
  5. After message Agent will be disconnected. We need to ignore runMessageLoopOnPause on step 3 during disconnecting.

Merge request reports