Skip to content

net: net.isIP() needs scope tests and a review of its type checking

Rodrigo Muino Tomonari requested to merge github/fork/lostnet/isip into master
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

net

Description of change

The IPv6 family and libuv support '%' notation for zoned scopes, so it should be tested. net.isIP() also has fewer checks before calling into libuv than other wrappers and could be more conservative without breaking castable Objects.

Merge request reports