Skip to content

deps: add back no-op harmony shipping flags

Rodrigo Muino Tomonari requested to merge github/fork/ofrobots/harmony-nops into v6.x-staging
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps:v8

Description of change

This PR adds back the shipping harmony flags (i.e. no-ops) that were removed in V8 5.1. While uses of V8 flags is generally not supported by Node, in this case a trivial change reduces minor hardship in the ecosystem by adding back these flags (and making them do nothing).

Fixes: https://github.com/nodejs/node/issues/8388 Ref: https://github.com/nodejs/node/pull/8395 R=@nodejs/v8 EDIT: CI: https://ci.nodejs.org/job/node-test-pull-request/3967/ CI: https://ci.nodejs.org/job/node-test-pull-request/4033/ V8-CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/310/

Merge request reports