Skip to content

tools: add additional ESLint rules

Rodrigo Muino Tomonari requested to merge github/fork/not-an-aardvark/linter-rules into master
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

Description of change

This enables the following ESLint rules, all of which are already followed in the vast majority of the codebase:

  • dot-location: On multiline property access, require the dot to be placed next to the property name rather than the object name. (1 existing violation)
  • no-useless-call: Disallow unnecessary Function.prototype.call expressions, e.g. foo.bar.call(foo). (0 existing violations)
  • no-useless-escape: Disallows characters in strings/regexes from being escaped with a backslash unless the backslash is actually doing something. (8 existing violations)
  • no-void: Disallows void expressions. (0 existing violations)
  • no-with: Disallows with statements. (0 existing violations)
  • comma-style: Require commas to be placed at the end of a line, rather than the beginning. (1 existing violation)
  • computed-property-spacing: When accessing a computed property (e.g. foo[bar]), disallow spaces inside the square brackets. (2 existing violations)
  • no-tabs: Disallow tab characters. (1 existing violation)
  • semi-spacing: Disallow spaces before semicolons, and require spaces after semicolons. (2 existing violations)

Merge request reports