Skip to content

test:replace indexOf, assert.equal, add mustCall

Rodrigo Muino Tomonari requested to merge github/fork/richHong/master into master
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

In test/parallel/test-fs-symlink.js:

Line 15: the use of o.indexOf() can be replaced with a usage of o.includes() which will make it more clear. Line 43: the use of assert.equal() can be assert.strictEqual() instead Line 28: the callback should be wrapped in common.mustCall() like in other instances of callbacks later in the file.

Merge request reports

Loading