Skip to content

build: add config.gypi to test/addons/.buildstamp

Rodrigo Muino Tomonari requested to merge github/fork/danbev/add-config.gypi-to-addons into v4.x-staging
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Description of change

This motivation for this commit is to enable a reconfiguration of the build type (Debug/Release) to be reflected by the addons tests.

Currently, when using configure --debug, and then running the tests, the addons build configurations (build/config.gypi) will not be updated. Adding config.gypi to the test/addons/.buildstamp target's prerequisites will cause the addons configurations to be updated when config.gypi has been updated.

Also, build-addons has been added as a prerequisite to the test target to have the addons rebuilt if the build type configuration has changed.

This is a backport of https://github.com/nodejs/node/pull/7893.

Merge request reports