Skip to content

inspector,test: zero out expectations

Rodrigo Muino Tomonari requested to merge github/fork/JaneaSystems/joaocgreis-GA8-zero-inspector into v6.x-staging
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Inspector (test)

Description of change

VS2013 was not running in CI for v6 when https://github.com/nodejs/node/pull/8832 landed. When compiling with VS2013 and running on Windows 2008, cctest.exe hangs consuming 100% CPU. This happens because Visual Studio 2013 does not zero out the expectations structure when allocating.

@nodejs/release this only needs to land if https://github.com/nodejs/node/issues/7989 is not approved before the next v6 release.

CI: https://ci.nodejs.org/view/All/job/node-test-commit/5512/

cc @nodejs/v8-inspector

Merge request reports