Skip to content

Benchmark fixes

Rodrigo Muino Tomonari requested to merge github/fork/AndreasMadsen/benchmark-fixes into master
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark

Description of change

Some minor benchmark fixes. I can create 3 separate pull requests if that makes the review process easier.

benchmark: fixes csv parsing given no parameters

When a benchmark did not contain any parameters the csv configuration filed would be "". In R this is by default parsed as NA, causing NA in the printout too.

Fixes: #9061 (closed)

benchmark: change the execution order

This changes the execution order from "iter, file, binary" to "file, iter, binary". This means the csv no longer has to buffered completely.

This also has the added effect that stopping compare.js early or interfering with performance only affects a single benchmark, instead of all of them.

Refs: #8659 (closed)

benchmark: use node v4 syntax in common.js

Using new syntax such as ...args means that the benchmark suite can't be used with older node versions. This changes the ...args syntax to a good old Array.prototype.slice.

Refs: https://github.com/nodejs/node/pull/8932#issuecomment-252924107

Merge request reports