Skip to content

test: skip whatwg url parse tests when icu is missing

Rodrigo Muino Tomonari requested to merge github/fork/jasnell/fix-test-whatwg-url-parsing into master
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

The WHATWG url parser relies on ICU's punycode implementation. A handful of the standard tests fail when ICU is not present because of the additional checks that are not implemented. For now, skip the parse tests if ICU is not present.

Merge request reports