Skip to content

test: move timer-dependent test to sequential

Rodrigo Muino Tomonari requested to merge github/fork/Trott/test-repl-timeout-throw into master
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test repl

Description of change

Timer-dependent tests fail frequently on certain platforms in CI when run in parallel with other tests, likely due to competition for resources. Move test-repl-timeout-throw to sequential to avoid this problem. Also did some minor refactoring (var->const and more use of assert.strictEqual of looser assertions).

@nodejs/testing @jbergstroem

Example failure: https://ci.nodejs.org/job/node-test-commit-freebsd/5147/nodes=freebsd10-64/console

Merge request reports