Skip to content

Implementation of --adjacent-node-modules to support module symlinking to global cache

Rodrigo Muino Tomonari requested to merge adj-nm into v7.x

Created by: ghost

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Modules

Description of change

Branched from v7.0.0 tag.

Using --adjacent-node-modules cmdline arg, or setting NODE_ADJACENT_NODE_MODULES, adds additional search paths for resolving prefix-less requires (i.e. require('somelib') ).

Details provided in this issue

It's expected this PR will be rejected for now, but there were some who wanted to take a peak first.

Test results

-------- Global test environment tear-down [==========] 26 tests from 2 test cases ran. (233 ms total) [ PASSED ] 26 tests. running 'python tools\test.py --mode=release addons doctool known_issues message parallel sequential -J' === release test-http-chunk-problem === Path: parallel/test-http-chunk-problem Command: C:\src\node\Release\node.exe C:\src\node\test\parallel\test-http-chunk-problem.js --- TIMEOUT --- === release test-process-kill-null === Path: parallel/test-process-kill-null Command: C:\src\node\Release\node.exe C:\src\node\test\parallel\test-process-kill-null.js --- TIMEOUT --- [03:37|% 100|+ 1257|- 2]: Done running jslint

C:\src\node>

Merge request reports