Skip to content

child_process: catch json parsing error in ipc

Rodrigo Muino Tomonari requested to merge github/fork/ktimothy/handle_ipc_channel_error into master
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

child_process (ipc)

Description of change

When starting an ipc with non-nodejs processes, it is possible that other side of communication will write some non-json data when sending a handle (socket/server/file descriptor/etc). It led to ipc being completely blocked - later messages are skipped.

This commit allows to catch errors in json parsing. Errors are simply ignored, reading of the ipc channel continues with next available bytes.

Merge request reports