Skip to content

Revert "buffer: runtime deprecation of calling Buffer without new"

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/revert-8169 into master
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

buffer

Description of change

This reverts commit f2fe5583 (https://github.com/nodejs/node/pull/8169) as the original justification for the runtime-deprecation does not appear to justify the disruption to Node’s existing ecosystem. Futhermore, the possibility of deprecating the Buffer constructor entirely in v8.0 might lead to people having to change their code twice (For the record: While I opened this PR and that roadmap is one that some people have in mind, I personally don’t think the Buffer constructor should be deprecated entirely in v8.0).

/cc @nodejs/ctc

Merge request reports