Skip to content

Backport removing let in for loop declaration

Rodrigo Muino Tomonari requested to merge github/fork/MylesBorins/no-let-in-loops into v4.x-staging
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

lib, tools, test, streams

Description of change

This is a backport of a number of commits that remove the use of let in for loop declarations.

It starts with #8873 that removes all instances of let, followed by #9171 to fix a regression introduced in streams, and finally #9049 which adds a linting rule to avoid regressing.

These changes have been living on v6.x and v7.x for a while and did show a decent improvement in performance. I would imagine it will only be more noticeable for v4.x. If anyone from @nodejs/benchmarking wants to chime in here that would be awesome

Merge request reports