Skip to content

timers: handle unrefed intervals in clearTimeout()

Rodrigo Muino Tomonari requested to merge github/fork/cjihrig/9561 into master
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

timers

Description of change

This commit clears the _repeat property of all timer objects in clearTimeout(). This prevents intervals passed to clearTimeout() from being rearmed.

Fixes: https://github.com/nodejs/node/issues/9561 (although it does not directly address wrap->object() issue described in https://github.com/nodejs/node/issues/9561#issuecomment-260340127)

R= @bnoordhuis

Merge request reports