Skip to content

backport: http: fix connection upgrade checks

Rodrigo Muino Tomonari requested to merge github/fork/mscdex/backport-v4-pr-8238 into v4.x-staging
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)
  • http
Description of change

This commit fixes connection upgrade checks, specifically when headers are passed as an array instead of a plain object to http.request().

This is a backport of https://github.com/nodejs/node/pull/8238.

CI: https://ci.nodejs.org/job/node-test-pull-request/4894/

Merge request reports