Skip to content

test: refactor common.js

Rodrigo Muino Tomonari requested to merge github/fork/Trott/globals into master
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • remove unused common.faketimeCli
  • remove mosly-unused common.testDir
  • assert.ok(false...) -> fail()
  • alphabetize list of known globals
  • .indexOf() -> .includes()

/cc @nodejs/testing

Merge request reports