Skip to content

test: refactor test-net-pingpong

Rodrigo Muino Tomonari requested to merge github/fork/targos/refactor-test-net-pingpong into master
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, net

Description of change
  • var -> const.
  • Verify that callbacks are called with common.mustCall.
  • Replace usage of deprecated server.connections.
  • Use common.fail instead of rethrowing errors.
  • Remove console.log statements.
  • assert.equal -> assert.strictEqual.
  • Correct order of arguments in assert.strictEqual.

Merge request reports