test: update test to use common.fail
Checklist
-
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passes -
tests and/or benchmarks are included -
commit message follows commit guidelines
Affected core subsystem(s)
Description of change
use common.fail instead of assert(false) also changes var to let & const as appropriate