Skip to content

Fix a crash when an Executor wrapped fork exit.

Rodrigo Muino Tomonari requested to merge github/fork/JoeDupuis/fix-crash-on-wrapped-fork-exit into 7-1-stable

Created by: JoeDupuis

Fix #51298

forking inside an Execution Wrapper crashes when running the completion callbacks.

Rails 7.0 was not Execution wrapping the runner command. Rails 7.2 changed the definition of active_connection?, the new definition doesn't contain the bug.

Therefore forking inside a script intended to be run with the runner command on 7.1 crashes. (see #51298)

This PR is targeting 7-1-stable

Edit: The regression test (with the fork) blew up the tests. I removed it, I'll revisit.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

Merge request reports