Skip to content

Add deprecation warnings for features to be removed/changed in RSpec 4

Rodrigo Muino Tomonari requested to merge add-major-update-deprecation-warnings into main

Created by: pirj

A few things are a bit off, e.g.:

  • no deprecation for multi-condition filtering usages 🤷
  • no specs for :if/:unless deprecation usages
  • had to flip the unless condition in snippet_extractor_spec.rb to skip it on Ruby 1.8 builds. Puzzled to understand how :unless => RSpec::Support::Ruby.jruby? && !RUBY_VERSION.start_with?('1.8.') was working (example failure)
  • should we add deprecation warnings when running on rbx/ree/Ruby < 2.3?

This is purposed to be released as version 3.99. Sibling PRs:

Release strategy: https://github.com/rspec/rspec-core/pull/2880#issuecomment-797756681 RSpec 4 plan: https://github.com/rspec/rspec/issues/61 Changes: https://github.com/rspec/rspec-core/blob/4-0-dev/Changelog.md#development

TODO

  • merge this PR, then rspec-expectations PR, then rspec-mocks PR
  • revert this spec/spec_helper.rb change

Merge request reports