Skip to content

802 fix call action ctrl and directive

username-removed-730944 requested to merge 802-fix-call-action-ctrl-and-directive into master

Closes #802 and #877

Problems was caused by CallAction.controller which was

  • shared between Assistant and Agent
  • called $state.go to state which existed only in Assistant
  • used CtiProxy (even in Agent!)
  • was using Lodash 4 (used in Assistant, but not Agent)
  • has a lot of functionality, but was not tested

Solution:

  • as much as possible functionality extracted (to callActionDropdown.directive, withPhoneState.directive, XucUtils.prettyPhoneNb)
  • the rest (three call actions) was split to different controller for Assistant and for Agent
  • added tests
  • Lodash in tests and in Agent was updated to version 4 (in bower_components)

Agent was using Lodash in three methods, all retested:

  • CallbackController.onCallbacksLoaded
  • QueueView.loadAgentQueues
  • CallbackDueService.onCallbackResult

For CCManager this means that it will use Lodash 3 in code but Lodash 4 in tests. But seems to be lesser of evils.

Merge request reports