Skip to content

Remove old ui dead code

username-removed-25042 requested to merge pserwylo/fdroidclient:remove-old-ui-dead-code into master

This commit removes all of the old code relating to:

  • The main screen with three tabs (Available, Installed, Updates).
  • The old AppDetails.
  • Any associated code (e.g. Adapters, layouts, some strings - but not all, etc).

I've broken it into a series of commits done in chronological order, which indicates the way I thought about verifying that the code I removed was indeed dead. Most of the stuff is straight removal of files or lines of code. Some of it required minor refactoring to deal with the removal.

While removing the code, I made sure to note down anything I was removing which had not been ported to the new UI. These all now live in the following issues: #904 #905, #906 (closed), #907 (closed), #908 (closed). Some of them are show stoppers for %0.103 - UX Overhaul (e.g. #906 (closed)) while others could wait if need be.

Looking forward to this because it will bring my ratio of additions : removals more in line. I don't enjoy being the developer who has added the most code to this project, I'd rather be known for removing code :)

Merge request reports