Skip to content
Snippets Groups Projects

Add methods for List of apkFiles

Closed username-removed-124398 requested to merge (removed):fix16 into master

#16 (closed): Not much yet but I think it is better than "not used".

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
63 63
64 64 @Override
65 65 protected void installPackageInternal(List<File> apkFiles) throws AndroidNotCompatibleException {
66 // not used
66 for (File apkFile : apkFiles) {
  • Hey @NicoAlt, the principle behind this sounds fine (i.e. I agree it is better than "// not used"). However, I believe that a for loop is not going to do what you require. I think the "startActivityForResult" is asynchronous, and so it may load up several install dialogs ontop of eachother. The correct behaviour would probably be to wait for a result from the REQUEST_CODE_INSTALL and then proceed onto the next one (or bail out from the process if cancelled).

    However, it may be that your solution is indeed better than nothing. To be honest it is a little tricky to know without having the implementation hooked up to the UI. Keen to see how this progresses though because I'm one of the many people who would actually use such a feature :)

  • @pserwylo Thank you for your feedback, I think you are right, this would load up several install dialogs ontop of eachother. I'll try to find another way for it.

    P.S.: I'm also one of the many people who would use this :D

  • username-removed-124398 Status changed to closed

    Status changed to closed

  • Please register or sign in to reply
    Loading