Enable nginx by default, and override the favicon to find the right tab easier

Enable nginx by default since we use it in production and it has broken things before ( https://gitlab.com/gitlab-org/gitlab-ce/issues/27054#note_21914305 )

Was also necessary (easier) to have a GDK-specific favicon for #186

Closes #186

Question: if we should use nginx infront of rails, should rails talk purely over unix-socket? Nginx currently binds on :3443 :3080 (TLS was removed)

One thing to consider - I often debug stuff using Wireshark. And having rails on unix socket didn't allow me just today to snoop directly on some traffic which I was interested in.

I know unix sockets also have some advantages over loopback but maybe it would be worth to at least consider the loopback address.

added 1 commit

• 5be36470 - no SSL on :3080

Compare with previous version

@pchojnacki Which information would not go through nginx? (This was why I made it a question instead of just replacing it )

If we put Nginx in front of rails then Workhorse will talk to Nginx instead of Rails, right ? If Workhorse will chat through loopback instead of socket then I'll be able to snoop on Workhorse <>Rails traffic which is enough for me. And I guess by default Nginx will probably serve requests via loopback interface.

So to answer your question: if nginx is in front of Rails then all information will go through nginx which is probably fine for my snooping needs.

added 3 commits

• 00cffe66 - Always rebuild nginx-config
• e149fe5f - use relative path or nginx craps out
• eb24268c - disable TLS since nginx fails w/o the cert-files

Compare with previous version

It's actually nginx <=> workhorse <=> rails, so you would need loopback to snoop workhorse <=> rails. Leaving it as is then ;)

added 1 commit

• c78d3c98 - Update prepare.md with nginx for homebrew

Compare with previous version

added home brew install recipe for mac :) for nginx

also still left to do:

• improve favicon to get rid of white borders, and perhaps change to blue (to be more professional)

added 1 commit

• 2dc0bd5d - use absolute path for favicon

Compare with previous version

added 1 commit

• 0b718f91 - updated favicon to include transparancy and be blue

Compare with previous version

updated favicon!

@jacobvosmaer-gitlab can we get this in ? cc: @bkc

I don't understand what we need this for. All I see in https://gitlab.com/gitlab-org/gitlab-ce/issues/2705 is a long discussion and a closed issue.

If something breaks because of production/development mismatch we should incorporate that something into workhorse. We should rely less and less on NGINX over time, not more.

@jacobvosmaer-gitlab The quick summary:

1. Merge request widget broke completely when it was shipped with omnibus. The problem was not reproducible with the GDK.
2. The Vue Resource had a bug where it was comparing against a case-sensitive Content-Type header name
3. When used with NGINX, the HTTP headers in Chrome appeared to be all lowercase (but not in Firefox)
4. The problem was not detected in development because NGINX was not in the path

We think NGINX is lowercasing the HTTP headers, and Firefox normalizes them the way Go does.

I don't understand what we need this for. All I see in gitlab-ce#2705 is a long discussion and a closed issue.

@jacobvosmaer-gitlab to have a different colored favicon for the gdk (https://gitlab.com/gitlab-org/gitlab-development-kit/issues/186), and to perhaps fix other things mentioned by @bkc

added enhancement label

Favicon-thingie already in Rails. Closing

closed