Skip to content
Snippets Groups Projects
Select Git revision
  • ag-test
  • rs-test
  • master default protected
  • test-me-pa
  • mksionek-master-patch-52381
  • new-branch-10
  • test-conflicts
  • test-suggestions
  • alejandro-test
  • patch-25
  • winh-test-image-doscussion
  • stg-lfs-image-test-2
  • stg-lfs-image-test
  • test42016
  • issue_42016
  • issue-32709
  • add-codeowners
  • ClemMakesApps-master-patch-62759
  • bvl-staging-test
  • bvl-merge-base-api
  • v9.2.0-rc6 protected
  • v9.2.0-rc5 protected
  • v9.2.0-rc4 protected
  • v9.2.0-rc3 protected
  • v9.1.4 protected
  • v9.2.0-rc2 protected
  • v9.2.0-rc1 protected
  • v9.1.3 protected
  • v8.17.6 protected
  • v9.0.7 protected
  • v9.1.2 protected
  • v9.1.1 protected
  • v9.2.0.pre protected
  • v9.1.0 protected
  • v9.1.0-rc7 protected
  • v9.1.0-rc6 protected
  • v9.0.6 protected
  • v9.1.0-rc5 protected
  • v9.1.0-rc4 protected
  • v9.1.0-rc3 protected
40 results

snippet.rb

  • Yorick Peterse's avatar
    580d2501
    Refactor Participable · 580d2501
    Yorick Peterse authored
    There are several changes to this module:
    
    1. The use of an explicit stack in Participable#participants
    2. Proc behaviour has been changed
    3. Batch permissions checking
    
    == Explicit Stack
    
    Participable#participants no longer uses recursion to process "self" and
    all child objects, instead it uses an Array and processes objects in
    breadth-first order. This allows us to for example create a single
    Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using
    a ReferenceExtractor removes the need for running potentially many SQL
    queries every time a Proc is called on a new object.
    
    == Proc Behaviour Changed
    
    Previously a Proc in Participable was expected to return an Array of
    User instances. This has been changed and instead it's now expected that
    a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return
    value of the Proc is ignored.
    
    == Permissions Checking
    
    The method Participable#participants uses
    Ability.users_that_can_read_project to check if the returned users have
    access to the project of "self" _without_ running multiple SQL queries
    for every user.
    580d2501
    History
    Refactor Participable
    Yorick Peterse authored
    There are several changes to this module:
    
    1. The use of an explicit stack in Participable#participants
    2. Proc behaviour has been changed
    3. Batch permissions checking
    
    == Explicit Stack
    
    Participable#participants no longer uses recursion to process "self" and
    all child objects, instead it uses an Array and processes objects in
    breadth-first order. This allows us to for example create a single
    Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using
    a ReferenceExtractor removes the need for running potentially many SQL
    queries every time a Proc is called on a new object.
    
    == Proc Behaviour Changed
    
    Previously a Proc in Participable was expected to return an Array of
    User instances. This has been changed and instead it's now expected that
    a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return
    value of the Proc is ignored.
    
    == Permissions Checking
    
    The method Participable#participants uses
    Ability.users_that_can_read_project to check if the returned users have
    access to the project of "self" _without_ running multiple SQL queries
    for every user.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.