Skip to content
Snippets Groups Projects
Commit 09c38e46 authored by Lin Jen-Shin's avatar Lin Jen-Shin
Browse files

Only pass item name

parent 94178149
No related branches found
No related tags found
1 merge request!3363Implement #3243 New Issue by email
Loading
Loading
@@ -42,9 +42,12 @@ module Gitlab
end.join
end
 
def verify_record!(record, exception, error_title)
def verify_record!(record, exception, name)
return if record.persisted?
 
error_title =
"The #{name} could not be created for the following reasons:"
msg = error_title + record.errors.full_messages.map do |error|
"\n\n- #{error}"
end.join
Loading
Loading
Loading
Loading
@@ -22,11 +22,7 @@ module Gitlab
 
validate_permission!(:create_issue)
 
verify_record!(
create_issue,
InvalidIssueError,
"The issue could not be created for the following reasons:"
)
verify_record!(create_issue, InvalidIssueError, 'issue')
end
 
def author
Loading
Loading
Loading
Loading
@@ -19,11 +19,7 @@ module Gitlab
raise NoteableNotFoundError unless sent_notification.noteable
raise EmptyEmailError if message.blank?
 
verify_record!(
create_note,
InvalidNoteError,
"The comment could not be created for the following reasons:"
)
verify_record!(create_note, InvalidNoteError, 'comment')
end
 
def author
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment