Use rake db:reset instead of db:setup

Using db:reset ensures existing tables are first dropped. This in turn
ensures that we can drop tables regardless of any foreign key
constraints. While CE currently doesn't have any foreign keys EE defines
the following relation:

    remote_mirrors.project_id -> projects.id

MySQL will complain whenever you try to drop the "projects" table first
even when using "DROP TABLE ... CASCADE".

bin/setup

@@ -18,7 +18,7 @@ Dir.chdir APP_ROOT do
   # end
   puts "\n== Preparing database =="
-  system "bin/rake db:setup"
+  system "bin/rake db:reset"
   puts "\n== Removing old logs and tempfiles =="
   system "rm -f log/*"

doc/development/rake_tasks.md

@@ -9,7 +9,7 @@ bundle exec rake setup
 ```
 The `setup` task is a alias for `gitlab:setup`.
-This tasks calls `db:setup` to create the database, calls `add_limits_mysql` that adds limits to the database schema in case of a MySQL database and finally it calls `db:seed_fu` to seed the database.
+This tasks calls `db:reset` to create the database, calls `add_limits_mysql` that adds limits to the database schema in case of a MySQL database and finally it calls `db:seed_fu` to seed the database.
 Note: `db:setup` calls `db:seed` but this does nothing.
 ## Run tests

lib/tasks/gitlab/setup.rake

@@ -14,7 +14,7 @@ namespace :gitlab do
       puts ""
     end
-    Rake::Task["db:setup"].invoke
+    Rake::Task["db:reset"].invoke
     Rake::Task["add_limits_mysql"].invoke
     Rake::Task["setup_postgresql"].invoke
     Rake::Task["db:seed_fu"].invoke

[username-removed-5302]

Uhm I think this broke GDK. rake db:reset seems to not create the database, unlike rake db:setup.

[username-removed-5302]

This whole thing makes no sense to me but "the seed script changes" and "GDK bootstrapping breaks" cannot be a coincidence, can it? Fixed mysteriously by https://gitlab.com/gitlab-org/gitlab-development-kit/commit/dc7c83bf7632ad44d9b1170abcd732b53a99bd4c

[username-removed-5302]

@marin I hope omnibus is not affected

[yorickpeterse-staging]

@jacobvosmaer rake db:reset is supposed to run db:drop followed by db:setup.

[yorickpeterse-staging]

From the Rails source code: https://github.com/rails/rails/blob/fbfc91de32dc04e19258e74283d8786edb21917f/activerecord/lib/active_record/railties/databases.rake#L156

[Marin Jankovski]

@jacobvosmaer I didn't notice any problems during the fresh installation. Thanks for the ping, I will keep it in mind.

[username-removed-5302]

@yorickpeterse I am not saying it makes sense. All I am saying is there is a suspicious chain of events. :)

Luckily, a non-sequitur change in GDK fixed it so everything ends well.