Skip to content

GitLab

Why GitLab
Pricing
Contact Sales
Explore

Sign in
Get free trial

Primary navigation

Project

GitLab FOSS
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Iterations
- Wiki
- Requirements
- Jira
- Releases
- Model registry
- Environments
- Incidents

Snippets Groups Projects

Admin message

Do not update/delete: Banner broadcast message test data

Admin message

Do not update/delete: Notification broadcast message test data

f8f97503

There was a problem fetching the pipeline summary.

Commit f8f97503 authored 10 years ago by Dmitriy Zaporozhets

Downloads
- Plain Diff

Merge branch 'username-period' into 'master'

Don't allow username to end in period.

The current behavior doesn't do username referencing and mentioning in sentences like "I discussed with with @douwe." since `douwe.` is matched as a username.

Addresses private issue https://dev.gitlab.org/gitlab/gitlabhq/issues/2174.

See merge request !438

parents 24b048db 45ee9009

Branches

Tags

No related merge requests found

Pipeline #

Changes 16
Pipelines 1

Hide whitespace changes

Inline Side-by-side

Showing

CHANGELOG 2 additions, 0 deletions

CHANGELOG
app/models/namespace.rb 31 additions, 16 deletions

app/models/namespace.rb
app/models/project.rb 3 additions, 3 deletions

app/models/project.rb
app/models/snippet.rb 2 additions, 2 deletions

app/models/snippet.rb
app/models/user.rb 2 additions, 18 deletions

app/models/user.rb
app/services/files/create_service.rb 2 additions, 2 deletions

app/services/files/create_service.rb
db/migrate/20150324133047_remove_periods_at_ends_of_usernames.rb 76 additions, 0 deletions

...ate/20150324133047_remove_periods_at_ends_of_usernames.rb
features/steps/project/source/browse_files.rb 1 addition, 1 deletion

features/steps/project/source/browse_files.rb
lib/gitlab/markdown.rb 1 addition, 1 deletion

lib/gitlab/markdown.rb
lib/gitlab/oauth/user.rb 1 addition, 1 deletion

lib/gitlab/oauth/user.rb
lib/gitlab/regex.rb 36 additions, 30 deletions

lib/gitlab/regex.rb
spec/lib/gitlab/regex_spec.rb 8 additions, 8 deletions

spec/lib/gitlab/regex_spec.rb
spec/models/namespace_spec.rb 10 additions, 2 deletions

spec/models/namespace_spec.rb
spec/models/user_spec.rb 0 additions, 10 deletions

spec/models/user_spec.rb
spec/requests/api/projects_spec.rb 2 additions, 2 deletions

spec/requests/api/projects_spec.rb
spec/requests/api/users_spec.rb 2 additions, 2 deletions

spec/requests/api/users_spec.rb

with 179 additions and 98 deletions

Loading

0% Loading or .

You are about to add 0 people to the discussion. Proceed with caution.

Finish editing this message first!

Please register or sign in to comment